JavaScript JavaScript and the DOM Getting a Handle on the DOM Practice Selecting Elements

Mohd Aamir Mir
Mohd Aamir Mir
3,281 Points
Posted by Mohd Aamir Mir
Mohd Aamir Mir
3,281 Points

need help with this one

Help with this one

js/app.js 
let navigationLinks= document.querySelectorAll('nav ul li');
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

2 Answers

<noob />
<noob />
17,034 Points
<noob />
<noob />
17,034 Points

Your very close. right now ur selecting all the list item element that contain the links inside them. u want only the links so you need to add to your selector the "a" tag

Steven Parker
Steven Parker
182,118 Points
Steven Parker
Steven Parker
182,118 Points

You don't need to specify every intermediate element in a descendant selector. You only need the outer container ("nav") and then the actual target, the link ("a").

Steven Parker
Steven Parker
182,118 Points
Steven Parker
Steven Parker
182,118 Points

Mohd Aamir Mir — Glad to help. You can mark a question solved by choosing a "best answer".
And happy coding!