Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

Posted by madison dagg
madison dagg
30 Points

Basic JavaScript code wont work.

The goal of this code is to output the greatest and least number given by the user, into the corresponding text box, however it isn't working. If someone could look over it and tell me any errors i have made, that would be awesome !

function determineMinimum(number1, number2) { if(number1 > number2) {return number1;} else{ return number2;} }

function dertermineMaximum(number1, number2) { if(number1 < number2) {return number1;} else{ return number2;} }

function btnMinMax_onclick() { // assign textbox elements to variables for easier access var firstTextbox = document.getElementById("txtNum1"); var secondTextbox = document.getElementById("txtNum2"); var minTextbox = document.getElementById("txtMin"); var maxTextbox = document.getElementById("txtMax");

var first = parseFloat(firstTextbox.value);
var second = parseFloat(secondTextbox.value);

var min = determineMinimum(number1, number2);
var max = dertermineMaximum(number1, number2);

minTextbox.value = min;
maxTextbox.value = max;

}

2 Answers

madison dagg
madison dagg
30 Points
madison dagg
madison dagg
30 Points

sorry, something weird happened there.

function determineMinimum(number1, number2)

{ if(number1 > number2) {return number1;} 

else{ return number2;}

}

function dertermineMaximum(number1, number2)

{ if(number1 < number2) {return number1;} 

else{ return number2;}

}

function btnMinMax_onclick() {

var firstTextbox = document.getElementById("txtNum1");

var secondTextbox = document.getElementById("txtNum2");

var minTextbox = document.getElementById("txtMin");

var maxTextbox = document.getElementById("txtMax");


var first = parseFloat(firstTextbox.value);

var second = parseFloat(secondTextbox.value);


var min = determineMinimum(number1, number2);

var max = dertermineMaximum(number1, number2);


minTextbox.value = min;

maxTextbox.value = max;

}

Owa Aquino
Owa Aquino
19,277 Points
Owa Aquino
Owa Aquino
19,277 Points

Hi Madison,

I'm just wondering how do you call the btnMinMax_onclick function. Should the code be like below? Sorry I'm just guessing here. :)

btnMinMax.onclick = function() {

var firstTextbox = document.getElementById("txtNum1");

var secondTextbox = document.getElementById("txtNum2");

var minTextbox = document.getElementById("txtMin");

var maxTextbox = document.getElementById("txtMax");


var first = parseFloat(firstTextbox.value);

var second = parseFloat(secondTextbox.value);


var min = determineMinimum(number1, number2);

var max = dertermineMaximum(number1, number2);


minTextbox.value = min;

maxTextbox.value = max;
}