Can someone explain to me why this loop isnt working?

Question

javascript
function randomNumber(top,lower){return Math.floor(Math.random() * (top - lower) + lower) + 1; randomNumber(100,10) var correctGuess= false;}
var attempts=0;
var random= randomNumber(100, 10);
while(correctGuess===false){var guess= randomNumber(100, 10); 
      if(guess===random){correctGuess===true;}
      attempts+=1;}

elk6 · Accepted Answer

Hi Brandon,
Multiple things. Your closing brackets are off. Half of what you wrote is inside the function body. Since you have a return statement right at the start, the rest will not get executed. And even if it would it would not work.
Also, you have written this: 
javascript
if(guess===random){correctGuess===true;}

This will not make correctGuess true but just checks if correctGuess equals true, since that is never the case ( it doesn't get changed after all ) you will get stuck in an endless loop.
So, try it like this, this might be what you are looking for:
javascript
function randomNumber(top,lower){
    return Math.floor(Math.random() * (top - lower) + lower) + 1; 
}
randomNumber(100,10) 
var correctGuess= false;
var attempts=0;
var random= randomNumber(100, 10);
while(correctGuess===false){
    var guess= randomNumber(100, 10); 
    if(guess===random){
        correctGuess=true;}
    attempts+=1;
  }

Also, might be because of copy/paste but try to keep your indentation like it should, this will make your code a lot more readable.
Elian

Welcome to the Treehouse Community

Looking to learn something new?

brandonlind2

brandonlind2

Can someone explain to me why this loop isnt working?

1 Answer

elk6

elk6