Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

"Cannot set property onclick of null"

When viewing the console, it keeps telling me there's a problem with deleteButton.onclick = deleteTask;

//Problem: User interaction doesn't provide deisred results //Solution: Add interactivity so the user can manage daily tasks

var taskInput = document.getElementById("new-task"); //new-task var addButton = document.getElementsByTagName("button")[0]; //first button var incompleteTaskHolder = document.getElementById("incomplete-tasks"); //incomplete-tasks var completedTasksHolder = document.getElementById("completed-tasks"); //completed-tasks

//New Task List Item var createNewTaskElement = function(taskString){ //Create list item var listItem = document.createElement("li"); //input (checkbox) var checkBox = document.createElement("input"); //checkbox //label var label = document.createElement("label"); //input (text) var editInput = document.createElement("input"); //text //button.edit var editButton = document.createElement("button"); //button.delete var deleteButton = document.createElement("delete");

//Each element needs modifying

checkBox.type = "checkbox"; editInput.type = "text";

editButton.innerText = "Edit"; editButton.className = "edit"; deleteButton.innerText = "Delete"; deleteButton.className = "delete";

label.innerText = taskString;

//Each element needs appending listItem.appendChild(checkBox); listItem.appendChild(label); listItem.appendChild(editInput); listItem.appendChild(editButton); listItem.appendChild(deleteButton);

return listItem; }

//Add a new task var addTask = function() { console.log("Add task...") //Create a new list item with the text from the #new-task: var listItem = createNewTaskElement(taskInput.value);

//Append listItem to incompleteTaskHolder incompleteTaskHolder.appendChild(listItem); bindTaskEvents(listItem, taskCompleted);

taskInput.value = ""; }

//Edit an existing task var editTask = function() { console.log("Edit task...")

var listItem = this.parentNode;

var editInput = listItem.querySelector("input[type=text"); var label = listItem.querySelector("label");

var containsClass = listItem.classList.contains("editMode");

//if the class of the parent is .editMode

if(containsClass) { //Switch from .editMode //Label text become the input's value label.innerText = editInput.value; } else { //Switch to .editMode //Input value becomes the label's text editInput.value = label.innerText; }

//Toggle .editMode on the list item

listItem.classList.toggle("editMode"); }

//Delete an existing task var deleteTask = function() { console.log("Delete task...") //Remove the parent list item from the ul var listItem = this.parentNode; var ul = listItem.parentNode;

//Remove the parent list item from the ul ul.removeChild(listItem); }

//Mark a task as complete var taskCompleted = function() { console.log("Task complete...") //Append the task list item to the #completed-tasks var listItem = this.parentNode completedTasksHolder.appendChild(listItem); bindTaskEvents(listItem, taskIncomplete); }

//Mark a task as incomplete var taskIncomplete = function() { console.log("Task incomplete...") //Append the task list item to the #incomplete-tasks var listItem = this.parentNode incompleteTaskHolder.appendChild(listItem); bindTaskEvents(listItem, taskCompleted); }

var bindTaskEvents= function(taskListItem, checkBoxEventHandler){ console.log("Bind list item events"); //select taskListItem's children var checkBox = taskListItem.querySelector("input[type=checkbox]"); var editButton = taskListItem.querySelector("button.edit"); var deleteButton = taskListItem.querySelector("button.delete");

//bind editTask to edit button

editButton.onclick = editTask;

//bind deleteTask to the delete button

deleteButton.onclick = deleteTask;

//bind checkBoxEventHandler to checkbox

checkBox.onchange = checkBoxEventHandler; }

var ajaxRequest = function() { //console.log("Ajax request"); }

//Set the click handler to the addTask function addButton.onclick = addTask; addButton.addEventListener("click", addTask); addButton.addEventListener("click", ajaxRequest); //addButton.onclick = ajaxRequest;

//cycle over incompleteTaskHolder ul list items for(var i = 0; i < incompleteTaskHolder.children.length; i++) { //bind events to list item's children (taskCompleted) bindTaskEvents(incompleteTaskHolder.children[i], taskCompleted); }

//cycle over completedTasksHolder ul list items for(var i = 0; i < completedTasksHolder.children.length; i++) {
//bind events to list item's children (taskIncomplete) bindTaskEvents(completedTasksHolder.children[i], taskIncomplete); }

can you post the HTML as well, or post a snapshot or your workspace?

2 Answers

Looks like you just have one minor issue. When you create the deleteButton element, you're attempting to create something other than a button.

var deleteButton = document.createElement("delete"); // This should be creating a button.

That resolved the error for me, but let me know if you run into any trouble. Happy coding! :)

https://w.trhou.se/j3hsfnonqx

There is the link for the snapshot.