Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Gary Stevenson
Gary Stevenson
2,310 Points
Posted by Gary Stevenson
Gary Stevenson
2,310 Points

Cant pass this assignment although code provides required outcome (List displays in rainbow colours)

Hi

When I preview the workspace it displays the list in rainbow colours but when I press " check work " it gives me an error message and wont pass this assignment.

code attached.

js/app.js 
var listItems = document.getElementsByClassName('rainbow');
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
};
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li class='rainbow'>This should be red</li>
      <li class='rainbow'>This should be orange</li>
      <li class='rainbow'>This should be yellow</li>
      <li class='rainbow'>This should be green</li>
      <li class='rainbow'>This should be blue</li>
      <li class='rainbow'>This should be indigo</li>
      <li class='rainbow'>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

1 Answer

teofanescucosmin
teofanescucosmin
14,058 Points
teofanescucosmin
teofanescucosmin
14,058 Points

Use .querySelectorAll 

var listItems = document.querySelectorAll('ul li');
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
};
Gary Stevenson
Gary Stevenson
2,310 Points
Gary Stevenson
Gary Stevenson
2,310 Points

Thanks for taking the time to respond!

Is there anything technically wrong with my solution or does the program just not accept it as an answer because they wanted me to do it in a specific way?