Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
Ruthba Yasmin
3,558 PointsCensore functionality not working properly
I'm getting the following error:
Whoops looks like you didn't censor the words (2a). mCensoredWords contains 'dork', but it made it past somehow.
package com.teamtreehouse;
import java.io.IOException;
public class Main {
public static void main(String[] args) {
Prompter prompter = new Prompter();
String story = null;
try {
story = prompter.newStoryTemplate();
} catch (IOException e) {
e.printStackTrace();
}
Template tmpl = new Template(story);
prompter.run(tmpl);
}
}
package com.teamtreehouse;
import java.io.*;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
public class Prompter {
private BufferedReader mReader;
private Set<String> mCensoredWords;
public Prompter() {
mReader = new BufferedReader(new InputStreamReader(System.in));
loadCensoredWords();
}
private void loadCensoredWords() {
mCensoredWords = new HashSet<String>();
Path file = Paths.get("resources", "censored_words.txt");
List<String> words = null;
try {
words = Files.readAllLines(file);
} catch (IOException e) {
System.out.println("Couldn't load censored words");
e.printStackTrace();
}
mCensoredWords.addAll(words);
}
public void run(Template tmpl) {
List<String> results = null;
try {
results = promptForWords(tmpl);
} catch (IOException e) {
System.out.println("There was a problem prompting for words");
e.printStackTrace();
System.exit(0);
}
String finalString = tmpl.render(results);
System.out.printf("Your TreeStory:%n%n%s", finalString);
}
/**
*
* Prompts for a new story template
* @return String
* @throws IOException
*/
public String newStoryTemplate() throws IOException{
String newStory;
System.out.println("Enter a new story template:");
newStory = mReader.readLine();
return newStory;
}
/**
* Prompts user for each of the blanks
*
* @param tmpl The compiled template
* @return
* @throws IOException
*/
public List<String> promptForWords(Template tmpl) throws IOException {
List<String> words = new ArrayList<String>();
for (String phrase : tmpl.getPlaceHolders()) {
String word = promptForWord(phrase);
words.add(word);
}
return words;
}
/**
* Prompts the user for the answer to the fill in the blank. Value is guaranteed to be not in the censored words list.
*
* @param phrase The word that the user should be prompted. eg: adjective, proper noun, name
* @return What the user responded
*/
public String promptForWord(String phrase) throws IOException{
System.out.printf("Please enter a %s: %n",phrase);
String response = mReader.readLine();
for (String censoredWords : mCensoredWords) {
if(response.equals(censoredWords)){
System.out.printf("%s is a censored word. Please try with a different word.%n", response);
response = mReader.readLine();
}
}
return response;
}
}
# This is essentially what I am testing
1. The user is prompted for a new string template (the one with the double underscores in it).
a. The prompter class has a new method that prompts for the story template, and that method is called.
2. The user is then prompted for each word that has been double underscored.
a. The answer is checked to see if it is contained in the censored words.
User is continually prompted until they enter a valid word
3. The user is presented with the completed story
2 Answers
Kevin Faust
15,353 PointsHey Ruthba,
The problem lies here:
public String promptForWord(String phrase) throws IOException{
System.out.printf("Please enter a %s: %n",phrase);
String response = mReader.readLine();
for (String censoredWords : mCensoredWords) {
if(response.equals(censoredWords)){
System.out.printf("%s is a censored word. Please try with a different word.%n", response);
response = mReader.readLine();
}
}
return response;
}
We actually dont have to loop through anything. We just need to check if our mCensoredWords contains the word we type in. We also can use a while statement. lets look at this:
while (mCensoredWords.contains(entryWord.toLowerCase()))
Here we check if our mCensoredWords contains the word we typed in. We use toLowerCase() because if you look at the censored words text file, it is all in lower case. If we typed in an upper case word then our bad word would pass through which is not good. So while our input is a bad word, we keep requesting them to enter a word. What you wrote in your if statement is correct. In terms of the rest of your code, it is fine. I have attached my code as reference:
public String promptForWord(String phrase) throws IOException {
System.out.printf("Please enter your word for %s: %n", phrase);
String entryWord = mReader.readLine();
while (mCensoredWords.contains(entryWord.toLowerCase())) {
System.out.printf("Be nice, please try another word for %s. %n", phrase);
entryWord = mReader.readLine();
}
return entryWord.trim();
}
If this helped, dont forget to mark as best answer so others with the same question can see.
Happy coding and best of luck,
Kevin
Ruthba Yasmin
3,558 PointsThanks a lot Kevin for the quick response! My program is working perfectly fine and I realized what the problem was!