Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by Vaidehi S
Vaidehi S
5,731 Points

Challenge 1. & list items needs to appear in 7 different colors? I am doing right yet it says error?

I have this code: var listItems = document.getElementById('rainbow'); var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < listItems.children.length; i++) { listItems.children[i].style.color = colors[i];
}

I got the output right in the console. Yet it says : Did you select all 7 items?

Why??

What is wrong?

js/app.js 
var listItems = document.getElementById('rainbow');
var colors = ["#C2272D", "#F8931F", "#FFFF01", 
              "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < listItems.children.length; i++) {
  listItems.children[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

3 Answers

Blake Larson
Blake Larson
13,014 Points
Blake Larson
Blake Larson
13,014 Points

That's my bad I didn't notice that you are grabbing the ul with the id rainbow. It wants you to grab all the li tags inside that.

var listItems = document.querySelectorAll('#rainbow li');
var colors = ["#C2272D", "#F8931F", "#FFFF01", 
              "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < listItems.length; i++) {
  listItems[i].style.color = colors[i];
}
Blake Larson
Blake Larson
13,014 Points
Blake Larson
Blake Larson
13,014 Points

You treat listItems like an array so you you don't need to call children.

for(var i = 0; i < listItems.length; i++) {
  listItems[i].style.color = colors[i];    
}
Vaidehi S
Vaidehi S
5,731 Points

I did this 1st but the output is all black lines. It doesnt change the color.

So I decided to go with children and it worked in output showing all the 7 rainbow colors but then it says : Did you select all the 7 list items?

This should be red This should be orange This should be yellow This should be green This should be blue This should be indigo This should be violet

Vaidehi S
Vaidehi S
5,731 Points
Vaidehi S
Vaidehi S
5,731 Points

Hi, Thanks. I figured that out.