Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

Posted by Jeremiah Bushau
Jeremiah Bushau
24,061 Points

Code review request - nodejs random media script

Hey, was hoping to get some feedback and ask some specific questions on the following script.

https://github.com/JerBushau/rm_stable

The purpose of the script is to quickly grab a specified number of tv or movie files and open them in vlc media player. It requires vlc settings to allow only one instance, otherwise it will open all the files into different instances of vlc, instead of adding them to the playlist. It is only tested on Linux.

My specific questions:

  1. Is this an appropriate use of Promise?
  2. Is there a way to kill this script after vlc has been started? (I originally wrote this script in python and the script returned to terminal prompt after starting vlc, however in node I have to use ctrl+c or wait until the playlist has ended before returning to terminal prompt.)
  3. Any cool ideas for new features?

Any other comments/notes/criticism welcome too. Thank you to anyone who takes the time to look through this :)