Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android Build a Simple Android App (2014) Improving Our Code Simple Refactoring: Using a Class

Goran Penov
Goran Penov
1,635 Points
Posted by Goran Penov
Goran Penov
1,635 Points

Error in FactBook.java

When I pasted the ten facts from the FunFactsActivity.java to my new class FactBook.java, a window pops up saying: 'Select classes to import' and my only option is the java.util.random class. I clicked ok, but I cannot run my app because it is full of errors: Error:(34, 3) error: reached end of file while parsing.Error:Execution failed for task ':app:compileDebugJava'.

Compilation failed; see the compiler error output for details. Please help. Tnx.

Stone Preston
Stone Preston
42,016 Points
Stone Preston
Stone Preston
42,016 Points

can you post your code please

Ratik Sharma
Ratik Sharma
32,885 Points
Ratik Sharma
Ratik Sharma
32,885 Points

Please post the entire code (including the import statements) in FactBook.java

2 Answers

Stone Preston
Stone Preston
42,016 Points
Stone Preston
Stone Preston
42,016 Points

looks like you forgot to close your getFact method with a } 

import java.util.Random;

/**
 * Created by user1 on 18/09/2014.
 */
public class FactBook {

    //Member variable (properties about the object)

    //Method (abilities: things the object can do)
    public String getFact(){
        String[] facts = {
                "Ants stretch when they wake up in the morning.",
                "Ostriches can run faster than horses.",
                "Olympic gold medals are actually made mostly of silver.",
                "You are born with 300 bones; by the time you are an adult you will have 206.",
                "It takes about 8 minutes for light from the Sun to reach Earth.",
                "Some bamboo plants can grow almost a meter in just one day.",
                "The state of Florida is bigger than England.",
                "Some penguins can leap 2-3 meters out of the water.",
                "On average, it takes 66 days to form a new habit.",
                "Mammoths still walked the earth when the Great Pyramid was being built."
        };
        // The button was clicked, so update the fact label with a new fact
        String fact = "";
        // Randomly select a fact
        Random randomGenerator = new Random();// Construct a new random generator
        int randomNumber = randomGenerator.nextInt(facts.length);

        fact = facts[randomNumber];
        return fact;
    //added a curly brace to close the method
    }
}
Goran Penov
Goran Penov
1,635 Points
Goran Penov
Goran Penov
1,635 Points 
package com.district42.coolfacts;

import java.util.Random;

/**
 * Created by user1 on 18/09/2014.
 */
public class FactBook {

    //Member variable (properties about the object)

    //Method (abilities: things the object can do)
    public String getFact(){
        String[] facts = {
                "Ants stretch when they wake up in the morning.",
                "Ostriches can run faster than horses.",
                "Olympic gold medals are actually made mostly of silver.",
                "You are born with 300 bones; by the time you are an adult you will have 206.",
                "It takes about 8 minutes for light from the Sun to reach Earth.",
                "Some bamboo plants can grow almost a meter in just one day.",
                "The state of Florida is bigger than England.",
                "Some penguins can leap 2-3 meters out of the water.",
                "On average, it takes 66 days to form a new habit.",
                "Mammoths still walked the earth when the Great Pyramid was being built."
        };
        // The button was clicked, so update the fact label with a new fact
        String fact = "";
        // Randomly select a fact
        Random randomGenerator = new Random();// Construct a new random generator
        int randomNumber = randomGenerator.nextInt(facts.length);

        fact = facts[randomNumber];
        return fact;
}
Ratik Sharma
Ratik Sharma
32,885 Points
Ratik Sharma
Ratik Sharma
32,885 Points

Remove everything in FactBook.java and then paste this into it: 

package com.district42.coolfacts;

import java.util.Random;

public class FactBook {

    // Member variable (properties about the object)
    public String[] mFacts = {
            "Ants stretch when they wake up in the morning.",
            "Ostriches can run faster than horses.",
            "Olympic gold medals are actually made mostly of silver.",
            "You are born with 300 bones; by the time you are an adult you will have 206.",
            "It takes about 8 minutes for light from the Sun to reach Earth.",
            "Some bamboo plants can grow almost a meter in just one day.",
            "The state of Florida is bigger than England.",
            "Some penguins can leap 2-3 meters out of the water.",
            "On average, it takes 66 days to form a new habit.",
            "Mammoths still walked the earth when the Great Pyramid was being built." };

    // Method (abilities: things the object can do)
    public String getFact() {

        String fact = "";

        // Randomly select a fact
        Random randomGenerator = new Random();  // Construct a new Random number generator
        int randomNumber = randomGenerator.nextInt(mFacts.length);

        fact = mFacts[randomNumber];

        return fact;
    }
}

What errors is Android Studio showing?