Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android Build a Self-Destructing Message Android App Capturing Photos and Videos Saving a Photo to the Gallery

Will Schwarz
Will Schwarz
2,795 Points
Posted by Will Schwarz
Will Schwarz
2,795 Points

External Storage error

I have the following code 

if(mMediaUri == null) {
                        //display an error
                        Toast.makeText(MainActivity.this, R.string.error_external_storage, Toast.LENGTH_LONG).show();
                    }
                    takePhotoIntent.putExtra(MediaStore.EXTRA_OUTPUT, mMediaUri);
                    startActivityForResult(takePhotoIntent, TAKE_PHOTO_REQUEST);
                    break;

Whenever I try to take a picture I get the error toast but the picture still saves to my phone. I really have no idea why this is. Any help is appreciated.

1 Answer

Andrew West
Andrew West
3,245 Points
Andrew West
Andrew West
3,245 Points

It looks like you just need to add an else so the lower portion of code only executes if the upper part doesn't.

if(mMediaUri == null) {
    //display an error
    Toast.makeText(MainActivity.this, R.string.error_external_storage, Toast.LENGTH_LONG).show();
} else {
    takePhotoIntent.putExtra(MediaStore.EXTRA_OUTPUT, mMediaUri);
    startActivityForResult(takePhotoIntent, TAKE_PHOTO_REQUEST);
}