Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

Feedback on my code please !

var students = [ 
  { 
   name: 'Dave',
    track: 'Front End Development',
    achievements: 158,
    points: 14730
  },
  {
    name: 'Jody',
    track: 'iOS Development with Swift',
    achievements: '175',
    points: '16375'
  },
  {
    name: 'Jordan',
    track: 'PHP Development',
    achievements: '55',
    points: '2025'
  },
  {
    name: 'John',
    track: 'Learn WordPress',
    achievements: '40',
    points: '1950'
  },
  {
    name: 'Trish',
    track: 'Rails Development',
    achievements: '5',
    points: '350'
  }
];


function print(message) {

  document.write(message);

}

  var name;
  var track;
  var achievements;
  var points;
  var html;

for (var i = 0 ; i < students.length; i += 1) {
   name = students[i].name;
   track = students[i].track;
   achievements = students[i].achievements;
   points = students[i].points;


   html = `<h2>Student: ${name}</h2>`
   html += `<p>Track: ${track}</p> `
   html += `<p>Achievements: ${achievements}</p> `
   html += `<p>Points: ${points}</p> `

  print(html);

}

1 Answer

Steven Parker
Steven Parker
231,110 Points

Three suggestions:

  • variables should always be declared as they are created (with "const", "let", or "var")
  • be consistent about indentation to indicate nesting level
  • creating variables to use just once isn't necessary (template tokens can contain indexing/membership)

Otherwise, looks very nice! Good job! :+1:

Thank you so much!