Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

CSS

Posted by Dean Conway
Dean Conway
3,301 Points

Feedback please?

Not really a question of sorts, just wanted to ask for some feedback on a project I am currently working on called Bassdrop, it is a fictional classroom project that I am using as a sandbox exercise to practice my HTML & CSS responsive coding skills. I need to come back and work on the branding, images and typography but for now I just wanted to focus on getting the layout to shift and change as I wanted it too at the different media sizes: mobile, tablet and desktop, What are the treehouse community thoughts? You can check it out here: deanconway.com/bassdrop

Patrik Horváth
Patrik Horváth
11,110 Points

My review

1st : your site is so good but its looks like static and without life for example give HOVER efect on elements

2nd : in news at Small MOBILE screens REMOVE this UGLY Screen size and make it FLEX COLUMN it will be better because image on 10x10px ( example ) is almost impasible see

3rd: FavIcon no works for your site :)

4th : Fix your CONSOLE PROBLEMS in my browser its 6 ERRORS :)

Failed to load resource: the server responded with a status of 404 (Not Found)
plugins.js Failed to load resource: the server responded with a status of 404 (Not Found)
main.js Failed to load resource: the server responded with a status of 404 (Not Found)
modernizr-2.8.3.min.js Failed to load resource: the server responded with a status of 404 (Not Found)
plugins.js Failed to load resource: the server responded with a status of 404 (Not Found)
main.js Failed to load resource: the server responded with a status of 404 (Not Found)

3 Answers

Henrik Christensen
.a{fill-rule:evenodd;}techdegree
Henrik Christensen
Python Web Development Techdegree Student 38,322 Points

I like it :-)

I have a few things that you might want to change/update/fix (or not) :-)

  • your navbar on mobile devices would look better if you made it in to a drop-down menu, because now it's taking up a lot of space.
  • your 'sign up' input field + button could use some styling (minor)
  • when I open the chrome developer tools I get 6 console errors that you might want to fix

By the way, in case you don't know, you can check out how your site looks on mobile devices and ipads if you open the developer tool and click on the mobile icon :-)

But over-all a really nice site you have created!

Keep coding! :-D

Dean Conway
Dean Conway
3,301 Points
Dean Conway
Dean Conway
3,301 Points

Hi Patrik,

Thanks for your feedback, and the initial compliment :)

1: When you say give hover effect on elements, any elements in particular?

2: Could you elaborate on point 2, not sure what you mean by REMOVE this UGLY Screen size and make it FLEX COLUMN what is ugly screen size? and make what into a flex column?

3: Also elaborate on point 3 please?

Patrik Horváth
Patrik Horváth
11,110 Points

1: for example when you hove at image it will be from Black and WHITE to colorfull or hover effects to your post .... and a lot of more

2: try resize your window to Minimum image for News posts are too small Flex colum ? ehmn you learn it soon if you continiu STUDY just make for mobile devices 1 element Per ROW

3: you dont have FAV ICON for your website

Dean Conway
Dean Conway
3,301 Points
Dean Conway
Dean Conway
3,301 Points

Thanks you both for the feedback you have provided so far it has been very helpful.

@Patrik, I understand what you mean about the images. But like i said before I would consider that a cosmetic treatment more than anything, and things like that i will come back to.

I can still read the news post headlines just fine so i assume you mean the image thumbnails to the left are to small?

Again, things like the favicon are just details that can be added in later - not a necessity right now.

@Henrik, Yes I was thinking of hiding the navigation behind one of those hamburger icons and then revealing it when the user clicks on the 3line icon (top right) don’t know how to code that at the mo, so will need to google that one :)

Like I said to Patrik above, the sign up button is all part of the styling treatment that I will need to come back to.

I think the console errors appear because I was originally using js on some parts of the site but have since removed the scripts because I could not work out why they were broken so I just removed them completely. - I had planned to use them as a sort filter on the reviews page.