JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

AJ Jhaveri
AJ Jhaveri
Full Stack JavaScript Techdegree Student 512 Points

getting invalid or unexpected token on setter challenge question

Not sure what i've done wrong, but the following challenge says to:

Inside the major() setter method, set the student's major to a backing property "major". If the student's level is Junior or Senior, the value of the backing property should be equal to the parameter passed to the setter method. If the student is only a Freshman or Sophomore, set the "major" backing property equal to 'None'.

I don't know what i am missing.

class Student { constructor(gpa, credits){ this.gpa = gpa; this.credits = credits; }

stringGPA() {
    return this.gpa.toString();
}

get level() {
    if (this.credits > 90 ) {
        return 'Senior';
    } else if (this.credits > 60) {
        return 'Junior';
    } else if (this.credits > 30) {
        return 'Sophomore';
    } else {
        return 'Freshman';
    }
}

set major(major) {
  if (this.level == 'Senior' || this.level == 'Junior) { 
      this._major = major;
      }
  else { this._major == 'None'; 
       }
}

}

var student = new Student(3.9, 60);

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

    set major(major) {
      if (this.level == 'Senior' || this.level == 'Junior) { 
          this._major = major;
          }
      else { this._major == 'None'; 
           }
    }
}

var student = new Student(3.9, 60);

3 Answers

Arturo, you are missing a closing bracket at the end of your code (just before the var student line). This will resolve the unexpected identifier. However you also have two more issues:

The backing property should be _major instead of _subject

Instead of student.level you should use this.level

Arturo Pérez Figueroa Pérez
Arturo Pérez Figueroa Pérez
3,809 Points

Thanks for the help Kris, I made all the changes an now a have a "Maximum call stack size exceeded" problem : (

You have two issues:

You are missing a closing quote on Junior. This is the cause of the unexpected token error.

this.level == 'Junior

Here you need the assignment operator:

this._major == 'None'
Arturo Pérez Figueroa Pérez
Arturo Pérez Figueroa Pérez
3,809 Points

Hi Community

I have the same problem, when I hit the check work button it return the "Unexpected identifier". Here is my code:

class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

    set major(major) {
      if(student.level === 'Senior' || student.level === 'Junior') {
        this._subject = major;
      } else {
        this._subject = 'None';
    }
}

var student = new Student(3.9, 60);