Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

HTML

Posted by Aurelian Spodarec
Aurelian Spodarec
10,801 Points

Good code for this menu?

HI,

So I'm making this menu, and I was wondering if this code that i written, the HTML markup is good, if that's what you would have, or woudl you change anythihng or such? 

    <!-- HEADER
    ================================================== -->
    <header class="header">

    <div class="header__top--panel">

        <ul class="l-inline-list">
            <li>
                <i class="fa fa-phone icon-color" aria-hidden="true"></i>
                Call us :2048 4342 2343
            </li>
            <li>
                <i class="fa fa-envelope icon-color" aria-hidden="true"></i>
                Email us: company@domain.com
            </li>
            <li>
                <i class="fa fa-clock-o icon-color" aria-hidden="true"></i>
                Working time: 08:00 - 17:00
            </li>
        </ul>
         <ul class="l-inline-list social-media">
            <li><a href="#"><i class="fa fa-facebook" aria-hidden="true"></i></a></li>
            <li><a href="#"><i class="fa fa-twitter" aria-hidden="true"></i></a></li>
            <li><a href="#"><i class="fa fa-instagram" aria-hidden="true"></i></a></li>
            <li><a href="#"><i class="fa fa-google-plus" aria-hidden="true"></i></a></li>
            <li><a href="#"><i class="fa fa-pinterest-p" aria-hidden="true"></i></a></li>
        </ul>
    </div><!-- /top-panel -->


    <div class="header__container">
        <div class="header__logo">
            <h1>LuxHomes</h1>
        </div><!-- /header__logo -->

        <div class="header__info">
            Get in touch with us
            <div class="header__info--phone">
                <i class="fa fa-phone" aria-hidden="true"></i>
                800-2345-6789
            </div>
        </div><!-- /header__info -->


    </div><!-- header__container -->

    <div class="header__main-menu">
        <nav class="header__nav">
        <ul class="nav-block">
            <li class="nav-block__item"><a class="nav-block__link" href="">Home</a></li>
            <li class="nav-block__item"><a class="nav-block__link" href="">Home</a></li>
            <li class="nav-block__item"><a class="nav-block__link" href="">Home</a></li>
            <li class="nav-block__item"><a class="nav-block__link" href="">Home</a></li>
        </ul>
        </nav>

        <div class="header__search">
            <input placeholder="Search...">
        </div>
    </div>
    </div><!-- /header-container -->

    </header>
Jonathan Ankiewicz
Jonathan Ankiewicz
17,901 Points

If it does what you need it should be good.

Aurelian Spodarec
Aurelian Spodarec
10,801 Points

Well, I can write an ugly code that does what it should, but then I need to meet industry standards. : p

1 Answer

Jonathan Ankiewicz
Jonathan Ankiewicz
17,901 Points
Jonathan Ankiewicz
Jonathan Ankiewicz
17,901 Points

True... It does look clean and good though, easily understandable.