Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

HTML

Posted by philipfrey
philipfrey
1,659 Points

How to Make a Website - Gallery margin issues

Hello!

I have a minor issue, the images in the gallery don't seem to have margins applied. It's probably nothing major, but I can't see the mistake.

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Filip Eckstein| Webdesign Enthusiast</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Dosis:400,700|Arvo:400,700,400italic' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
  </head>
  <body>
    <header>
      <a href="index.html" id=logo>
        <h1>Filip Eckstein</h1>
        <h2>Webdesign Enthusiast</h2>
      </a>
       <nav>
          <ul>
            <li><a href="index.html" class="selected">Current Skills</a></li>
            <li><a href="monologue.html"> About</a></li>
            <li><a href="horrors.html">Contact</a></li>
          </ul>
        </nav>
      </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/basichtml.jpg">
              <img src="img/basichtml.jpg" alt="">
              <p>Basic websites...</p>
            </a>
          </li>
          <li>
            <a href="img/basiccss.gif">
              <img src="img/basiccss.gif" alt="">
              <p>...with basic styles.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://www.twitter.com"><img src="img/twitter-wrap.png" alt="twitter logo" class="social-icon"></a>
        <a href="https://www.facebook.com/eckstein.fulop"><img src="img/facebook-wrap.png" alt="facebook logo" class="social-icon"></a>
        <p>&copy; 2014 Filip Eckstein</p>
      </footer>
    </div>
  </body>
</html>

/**********************************
GENERAL
***********************************/

body {
  font-family: 'Arvo', sans-serif;
}

#wrapper {
  max-width: 940px;
  margin: 0 auto;
  padding: 0 5%;
}

a {
  text-decoration: none;
}

img {
  max-width: 100%;
}



/**********************************
HEADING
***********************************/

header {
  float: left;
  margin: 0 0 30px 0;
  padding: 5px 0 0 0;
  width: 100%;
}

#logo {
  text-align: center;
  margin: 0;
}

h1 {
  font-family: 'Dosis', sans-serif;
  margin: 15px 0;
  font-size: 1.75em;
  font-weight: normal;
  line-height: 0.8em;
}

h2 {
  font-size: 0.75em;
  margin: -5px 0 0;
  font-weight: normal;
}



/**********************************
NAVIGATION
***********************************/

nav {
  text-align: center;
  padding: 10px 0;
  margin: 20px 0 0;
}

nav ul {
  list-style: none;
  margin: 0 10px;
  padding: 0;
}

nav li {
  display: inline-block;
}

nav a {
  font-weight: 800;
  padding: 15px 10px;
}



/**********************************
FOOTER
***********************************/

footer {
  font-size: 0.75em;
  text-align: center;
  clear: both;
  padding-top: 50px;
  color: #ccc;
}

.social-icon {
  width: 20px;
  height: 20px;
  margin: 0 5px;
}



/**********************************
PAGE: SKILLS
***********************************/

#gallery {
  margin: 0;
  padding: 0;
  list-style: none;
}

#gallery li {
  float: left;
  width: 45%;
  margin: 0 2.5% 0 2.5%;
  background-color: #f5f5f5;
  color: #bdc3c7;
}

#gallery li a p {
  margin: 0;
  padding: 5%;
  font-size: 0.75em;
  color: #bdc3c7
}


/**********************************
COLORS
***********************************/

/* site body */
body {
  background-color: #fff;
  color: #999;
}

/* green header */
header {
  background: #6ab47b;
  border-color: #599a68;
}

/* nav background on mobile */
nav {
  background: #599a68;
}

/* logo text */
h1, h2 {
  color: #fff;
}

/* links */
a {
  color: #6ab47b;
}

/* nav link */
nav a, nav a:visited {
  color: #fff;
}

/* selected nav link */
nav a.selected, nav a:hover {
  color: #32673f;
}

1 Answer

philipfrey
philipfrey
1,659 Points
philipfrey
philipfrey
1,659 Points

Fixed, thank you!