Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

NAJEEBULLAH KHAN
NAJEEBULLAH KHAN
2,967 Points
Posted by NAJEEBULLAH KHAN
NAJEEBULLAH KHAN
2,967 Points

i dont know what it wants from me i did every thing that is asked

why

Order.java 
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = discountCode;
  }
 private String normalizeDistcountCode(String discountCode) {

      this.discountCode = discountCode;
      discountCode = discountCode.toUpperCase();
      return discountCode;
}
}
Example.java 
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

andren
andren
28,558 Points
andren
andren
28,558 Points

The instructions specify that you should call the normalizeDiscountCode method from the applyDiscountCode method, also you mispelled the normalizeDiscountCode method as normalizeDistcountCode (you added a t).

On top of that the purpose of the normalizeDiscountCode is just to uppercase the discount code and return it, so the first line you have placed in the method is unnecessary. And the other two lines can be combined into one.

The two methods should look like this:

public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
}
private String normalizeDiscountCode(String discountCode) {
    return discountCode.toUpperCase();
}