Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Creating the MVP Remaining Tries

Agnes Demes
Agnes Demes
6,613 Points

Iam stuck in an endless loop, cannot find why...

public class Game{
  public static final int MAX_MISSES = 7;
 private String answer;
 private String hits;
  private String misses;

  public Game (String answer){
    this.answer = answer;
    hits ="";
    misses="";
  }
  public boolean applyGuess(char letter){
    boolean isHit = answer.indexOf(letter) !=-1;
    if(isHit){
      hits+= letter;
    }else {
      misses+=letter;
    }return isHit;
  }
  public int getRemainingTries(){
    return MAX_MISSES - misses.length();
  }
   public String getCurrentProgress(){
     String progress ="";

     for ( char letter : answer.toCharArray()){
       char display = '-';
       if (hits.indexOf(letter) !=-1){
         display = letter;
       }
       progress += display;
     }
     return progress;

  }
}


public class Hangman {

  public static void main(String[] args) {
  Game game = new Game("treehouse");
  Prompter prompter = new Prompter(game);

    while (game.getRemainingTries() >0){

  prompter.displayProgress();
  prompter.promptForGuess();
    }

  }
}


import java.util.Scanner;

public class Prompter{
  private Game game;

  public Prompter(Game game){
    this.game=game;
  }
  public boolean promptForGuess(){
    Scanner scanner = new Scanner(System.in);
    System.out.print("Enter a letter  ");
    String guessInput = scanner.nextLine();
    char guess = guessInput.charAt(0);
    return game.applyGuess(guess);
  }
  public void displayProgress(){
    System.out.printf("You have %d tries, left to solve  %s%n",
                      game.getRemainingTries(),
                      game.getCurrentProgress());
  }
}

2 Answers

Agnes Demes
Agnes Demes
6,613 Points

uhhhm it is now working not sure why it didnt

Tyler B
Tyler B
5,787 Points
while (game.getRemainingTries() >0){

  prompter.displayProgress();
  prompter.promptForGuess();
    }

this will loop until RemainingTries is less then 0. There are 2 problems here the first is that you are not reducing the number for remaining tries as you loop (causing an infinite loop) and the other is that by checkout for less then 0 you will get one more try then you intended. Hope that helps!