Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Posted by antonio reyes
antonio reyes
Courses Plus Student 1,902 Points

Im using the document.querySelectorAll for the UL in the NAV and am not getting the appropriate results.Please help.

js/app.js

js/app.js 
let navigationLinks = document.querySelectorAll("ul");
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul class="win">
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

1 Answer

Trent Ungard
Trent Ungard
10,533 Points
Trent Ungard
Trent Ungard
10,533 Points

Hello Antonio! Your code appears to be targeting all 'ul' elements when your description seems to communicate that you actually want to select the li items within. Running querySelectorAll on the ul tag will return all ul tags, even outside of the nav. What you would want to do if you simple want the navigation list items is pass ".win li" to document.querySelectorAll so that it only selects the list items within the .win class, without selecting the other li's on your page or the ul that also isn't the one you want. Alternatively you could pass "nav ul li" so as to make it more clear that you only want the li tags within the ul tag within your nav tag.

Hope this helps!

antonio reyes
antonio reyes
Courses Plus Student 1,902 Points

AWESOME feedback, however after trying the answers provided I still couldn't move forward in the assignment. I know this answer to be correct since it'll work in other environments. Thanks!