Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Java Java Objects Delivering the MVP Applying a Discount Code

Shirit Dori
Shirit Dori
791 Points

In line 28, why do i get a bummer which tells me : unreachable statement if(!discountCode.matches("[a-zA-Z/$]+")){

I don't know what i'm doing wrong... i get the message "unreachable statement if.

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }
   public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
private String normalizeDiscountCode(String discountCode){
  discountCode=discountCode.toUpperCase();
  return discountCode;
  if(!discountCode.matches("[a-zA-Z/$]+")){
     throw new IllegalArgumentException("Invalid discount code");
   }
  return discountCode.toUpperCase();
}
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Amrit Pandey
Amrit Pandey
17,595 Points

I did'nt understand what you wanted to say but hey look, you made one terrible mistake!

private String normalizeDiscountCode(String discountCode){
  discountCode=discountCode.toUpperCase();
  return discountCode;
  if(!discountCode.matches("[a-zA-Z/$]+")){
     throw new IllegalArgumentException("Invalid discount code");
   }
  return discountCode.toUpperCase();
}

On line 4, you already returned the discountCode, anything after that will not be executed. This is the reason why you get Unreachable error.

private String normalizeDiscountCode(String discountCode){
  discountCode=discountCode.toUpperCase();
  if(!discountCode.matches("[a-zA-Z/$]+")){
     throw new IllegalArgumentException("Invalid discount code");
   }
  return discountCode;
}

thanks resolved the second task. i was retrning without uppercase.

Amrit Pandey
Amrit Pandey
17,595 Points

If this works for you then please mark it as Best Answer so others can see it. Thanks.