In the normalizeDiscountCode verify that only letters or the $ character are used. What am I doing wrong?

Question

public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;
  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }
  public String getItemName() {
    return itemName;
  }
  public int getPriceInCents() {
    return priceInCents;
  }
  public String getDiscountCode() {
    return discountCode;
  }
  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
  private String normalizeDiscountCode(String discountCode) {
    for(char letter : discountCode.toCharArray()) {
      if(!Character.isLetter(letter) || letter != '$'){
        throw new IllegalArgumentException("Invalid discount code");
      }else{
        return discountCode.toUpperCase();
      }
    }
  }
}

Eduardo Mejía · Accepted Answer

Thank you it was not just the operator || since I had already tried it in both ways but it did not work, in the same way the else considered it wrong and that is the solution
public class Order { 
private String itemName;

private int priceInCents;

private String discountCode;
  public Order(String itemName, int priceInCents) { 
this.itemName = itemName;

this.priceInCents = priceInCents; 
  }
  public String getItemName() { 
return itemName; 
  }
  public int getPriceInCents() { 
return priceInCents; 
  }
  public String getDiscountCode() { 
return discountCode; 
  }
  public void applyDiscountCode(String discountCode) { 
this.discountCode = normalizeDiscountCode(discountCode); 
  }
  private String normalizeDiscountCode(String discountCode) { 
for(char letter : discountCode.toCharArray()) {

if(!Character.isLetter(letter) && letter != '$'){

throw new IllegalArgumentException("Invalid discount code");

}

return discountCode.toUpperCase();
  }
}

alastair cooper · Answer

!Character.isLetter(letter) || letter != '$' 
Your problem is the logic in the if statement. Not this OR Not that allows almost anything.
Try changing the || to &&
if it is not a letter AND it is not $   ...   ie    !Character.isLetter(letter) && letter != '$'

alastair cooper · Answer

can't help you without seeing your code, but the error message would suggest that there is a method that should return a value that doesn't return anything at the moment

Welcome to the Treehouse Community

Looking to learn something new?

Eduardo Mejía

Eduardo Mejía

In the normalizeDiscountCode verify that only letters or the $ character are used. What am I doing wrong?

3 Answers

Eduardo Mejía

Eduardo Mejía

alastair cooper

alastair cooper

Eduardo Mejía

Eduardo Mejía

alastair cooper

alastair cooper