Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Posted by Shreemangal Sethi
.a{fill-rule:evenodd;}techdegree
Shreemangal Sethi
Full Stack JavaScript Techdegree Student 15,552 Points

let navigationLinks = document.querySelectorAll('nav ul li'); I don't know why this is wrong?

Selecting all the links under nav tag with descendant selector "nav ul li" could someone please tell me why this is wrong.

js/app.js 
let navigationLinks = document.querySelectorAll('nav ul li');
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

4 Answers

Bihari Sharma
.a{fill-rule:evenodd;}techdegree
Bihari Sharma
Front End Web Development Techdegree Student 235 Points

u can write ur code like this:

let navigationLinks = document.querySelectorAll('nav a'); u think list as link it happens bro iif it helpsp u then click on it as the best answer

Bihari Sharma
seal-mask
.a{fill-rule:evenodd;}techdegree
Bihari Sharma
Front End Web Development Techdegree Student 235 Points
Bihari Sharma
.a{fill-rule:evenodd;}techdegree
Bihari Sharma
Front End Web Development Techdegree Student 235 Points

can u tell me more briefly what is your problem ?

Bihari Sharma
seal-mask
.a{fill-rule:evenodd;}techdegree
Bihari Sharma
Front End Web Development Techdegree Student 235 Points
Bihari Sharma
.a{fill-rule:evenodd;}techdegree
Bihari Sharma
Front End Web Development Techdegree Student 235 Points

u have to select all the a tags not the list tags hope this help u

Shreemangal Sethi
seal-mask
.a{fill-rule:evenodd;}techdegree
Shreemangal Sethi
Full Stack JavaScript Techdegree Student 15,552 Points
Shreemangal Sethi
.a{fill-rule:evenodd;}techdegree
Shreemangal Sethi
Full Stack JavaScript Techdegree Student 15,552 Points

Thanks Bihari i got it. It was actually all the descendants of nav tag so my code is "let navigationLinks = document.querySelectorAll('nav ol li a');"