Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by Chris Erick
Chris Erick
5,989 Points

listItems = document.querySelectorAll('ul.rainbow') Isn't working as expected, all ul items are black

This code produces an unexpected error when the for loop attempts to iterate over listItems

js/app.js 
var listItems = document.querySelectorAll('ul.rainbow');
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

1 Answer

Xavier Ritch
Xavier Ritch
11,099 Points
Xavier Ritch
Xavier Ritch
11,099 Points

hey not sure if you got it already but if not, since the elements you want to select are the children of an element that has an id, always use # to select id's and then select all the corresponding children with their element tags.

so your code should look like this: var listItems = document.querySelectorAll('#rainbow li');