Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Bella Bradbury
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Bella Bradbury
Front End Web Development Techdegree Graduate 32,790 Points

Maximum Call Stack Size Exceeded

Any help would be greatly appreciated!

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

    set major(major) {      
      if ( this._level === 'Senior' || this._level === 'Junior') {
        this._major = 'major';
      } else {
        this.major = 'None';
      }
    }
}

var student = new Student(3.9, 60);

1 Answer

Steven Parker
Steven Parker
229,732 Points

I see 3 issues:

  • the level property is provided by a getter, so the name should be "level" instead of "_level"
  • variable or parameter names (like major) should not be enclosed in quotes
  • the backing property name on the last line should be "_major" (with underscore)