Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Bella Bradbury
seal-mask
.a{fill-rule:evenodd;}techdegree
Bella Bradbury
Web Development Techdegree Student 9,092 Points

Maximum Call Stack Size Exceeded

Any help would be greatly appreciated!

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

    set major(major) {      
      if ( this._level === 'Senior' || this._level === 'Junior') {
        this._major = 'major';
      } else {
        this.major = 'None';
      }
    }
}

var student = new Student(3.9, 60);

1 Answer

Steven Parker
Steven Parker
215,958 Points

I see 3 issues:

  • the level property is provided by a getter, so the name should be "level" instead of "_level"
  • variable or parameter names (like major) should not be enclosed in quotes
  • the backing property name on the last line should be "_major" (with underscore)