Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Posted by Gerald Wells
Gerald Wells
12,763 Points

ModelForm not saving

When I go to my template and input a driver number it returns "Field is required". I am not sure why It wont save to my database and isn't recognizing the fact that I have input'd information.

models.py

class TimeClockIN(models.Model):
    timestamp = models.DateTimeField()
    driver_number = models.IntegerField(max_length=8)   
    driver = models.ForeignKey(Driver, blank=True)

forms.py

class ClockInForm(forms.ModelForm):
    class Meta:
        model = models.TimeClockIN
        fields = [
            'driver_number',



        ]

views.py

def clock_in_view(request):
    form = forms.ClockInForm()
    pull_all = Driver.objects.all()

    if request.method == 'POST':
        form = forms.ClockInForm(request.GET)
        if form.is_valid(): 
            for driver in pull_all:
                if request in driver.driver_number:
                    time_in_instance = form.save(commit=False)
                time_in_instance.timestamp = timezone.now()
                time_in_instance.save()
                messages.add_message(request, messages.SUCCESS,
                                        "Clocked IN")
                return HttpResponseRedirect(reverse('clockin'))
            else:
                form = forms.ClockInForm()




    return render(request, 'clockinform.html', {'form': form})
Gerald Wells
Gerald Wells
12,763 Points

So I believe my issue is coming from .GET, It needs to be .POST. however when I change this I get a

TypeError:argument of type 'int' is not iterable

I am confused as to what to do to fix this issue

1 Answer

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,468 Points
Chris Freeman
Chris Freeman
Treehouse Moderator 68,468 Points

Hi Gerald, if the request method is POST this is the correct line:

form = forms.ClockInForm(request.GET)

Can you post the full traceback message after you make this change?

The line:

if request in driver.driver_number:

Will throw the error you mentioned if driver_number is an int since integers can not be iterated. Maybe use:

if request == driver.driver_number:
Gerald Wells
Gerald Wells
12,763 Points

I actually fixed it, the rewrote View is:

def clock_in_view(request):
    form = forms.ClockInForm()

    if request.method == 'POST':
        form = forms.ClockInForm(request.POST)
        if form.is_valid(): 
            try: 
                driver = Driver.objects.get(driver_number=form.cleaned_data['driver_number'])
                time_in_instance = TimeClockIN()
                time_in_instance.timestamp = timezone.now()
                time_in_instance.driver = driver
                time_in_instance.save()
                #messages.add_message(request, messages.SUCCESS,
                #                    "Clocked IN")
                return HttpResponseRedirect(reverse('clockin'))
            except Driver.DoesNotExist:
                form = forms.ClockInForm()
    return render(request, 'clockinform.html', {'form': form})