JavaScript Object-Oriented JavaScript Getters and Setters Creating Getter Methods

Joseph Chauvin
Joseph Chauvin
Full Stack JavaScript Techdegree Student 10,353 Points

My getter method is not returning a value

My getter method is not returning a value even with my if statements.

creating_getters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

  get level() {
    if (this.credits > 90) {
      return 'Senior';
    } else if (this.credits < 90 && this.credits >= 61) {
      return 'Junior';
    } else if (this.credits < 60 && this.credits >= 31) {
      return 'Sophomore';
    } else if (this.credits < 30) {
      return 'Freshman';
    }
  }
}

const student = new Student(3.9);

1 Answer

Fernando Boza
Fernando Boza
24,508 Points

Joseph Chauvin you're almost right there, if you see the instructions it's asking you

If the student has 90 or fewer credits, but more than 60 (>= 61), they are a 'Junior'.

you current conditional is only checking if a student less than 90 ( 89, 88, 87 ... ) remember to check for 90 and below we add <= or less than or equals to

this.credits <= 90 && this.credits >= 61