Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Piyush Patel
Piyush Patel
17,253 Points

Need help solving this challenge

I am unable to resolve this problem. I do not know what is wrong with this solution. Please, check.

var utilities = require("./utilities");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
function merge(content, values) {
  for (key in content) {
    content = content.replace("%" + key + "%", values[key]); 
  return content;

module.exports.merge = merge;

1 Answer

Steven Parker
Steven Parker
218,691 Points

You seem to be iterating on the wrong argument.

Instead of iterating on the content, you probably intended to do it using the values:

  for (key in values) {