Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Piyush Patel
Piyush Patel
17,253 Points

Need help solving this challenge

I am unable to resolve this problem. I do not know what is wrong with this solution. Please, check.

var utilities = require("./utilities");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
function merge(content, values) {
  for (key in content) {
    content = content.replace("%" + key + "%", values[key]); 
  return content;

module.exports.merge = merge;

1 Answer

Steven Parker
Steven Parker
228,978 Points

You seem to be iterating on the wrong argument.

Instead of iterating on the content, you probably intended to do it using the values:

  for (key in values) {