Not sure what my problem is with this Code.

Question

I've tried everything that I could think of. Can someone please explain to me my error? After I try and complete task 2, it tells me that task 1 can no longer pass.

Order.java

public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }  
  private String normalizeDiscountCode(String discountCode){
    if(! discountCode.matches("[a-zA-Z]+")|| ! discountCode.matches("[$]*")){
    throw new IllegalArgumentException("Invalid discount code.");
    }
    this.discountCode = discountCode;
        return discountCode.toUpperCase();
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
}

Example.java

public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

Answer 1 · 2017-07-15T16:23:55Z

July 15, 2017 4:23pm

So issue one you are setting have some duplicates

this is not needed:

private String normalizeDiscountCode(String discountCode){
// if you add a $ to the first regex expression and  replace the || (or) with a && (and) statement it will pass
// you might not even need the second statement 
    if(! discountCode.matches("[$a-zA-Z]+")|| ! discountCode.matches("[$]*")){
    throw new IllegalArgumentException("Invalid discount code.");
    }
// this can be removed because you are setting it in the apply method by calling this method and returning it
    this.discountCode = discountCode;
        return discountCode.toUpperCase();
  }

Welcome to the Treehouse Community

Looking to learn something new?

Theodore Lewis

Theodore Lewis

Not sure what my problem is with this Code.

1 Answer

Joshua O'Brian

Joshua O'Brian