Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Random Number Challenge Solution

Assem Zhilkibayeva
Assem Zhilkibayeva
5,717 Points

Random numbers out of range

Here is code which I wrote:

function RandomNumber(upper, lower) {

var upper = prompt('Give an upper value'); var lower = prompt('Give a lower value'); return Math.floor(Math.random() * (upper - lower + 1)) + lower;

}

alert(RandomNumber());

The issue is that in the end answers are completely out of range which is given by upper and lower value

1 Answer

Steven Parker
Steven Parker
215,984 Points

Your random formula is good, but you forgot to convert the strings from the prompt into numbers first. You can do this with parseInt.

Also, you should probably not declare the parameters in the function definition since the function would ignore them anyway.