Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops The Refactor Challenge, Part 2

Posted by nagamani palamuthi
nagamani palamuthi
6,160 Points

refactoring using functions code check

https://w.trhou.se/swp4q08x58

Hi the code above works . I want to know if that is a reasonable way to write the code.

1 Answer

David Kanwisher
David Kanwisher
9,751 Points
David Kanwisher
David Kanwisher
9,751 Points

Your function is inside your FOR loop. For every iteration of your loop, your function is being defined again. In this example it's sort of like typing out your function 10 times. It still works, but it's redundant. Place the function outside of your loop.