Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Refactor

reflector

i need help

shopping_list.py
def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list
def main():    
    show_help()

# make a list to hold onto our items
    shopping_list = []

    while True:
    # ask for new items
         new_item = input("> ")

    # be able to quit the app
         if new_item == 'DONE':
                break
        elif new_item == 'HELP':
             show_help()
                continue
        elif new_item == 'SHOW':
             show_list(shopping_list)
                continue
    add_to_list(shopping_list, new_item)

show_list(shopping_list)
  main()

1 Answer

There are a few issues with your code:

First, the continue key words in the HELP and SHOW blocks should be at the same level of indentation as the lines above them.

elif new_item == 'HELP':
    show_help()
    continue
elif new_item == 'SHOW':
    show_list(shopping_list)
    continue

Second, the line show_list(shopping_list) which is currently just above the call to the main function needs to be indented four spaces to line up with the rest of the code inside the main function.

Finally, you do not need to call the main function as you have done in the last line of the code.

NOTE: I don't think it will cause your code to not pass the tests, but to adhere to best practice your break statement should only be indented four spaces rather than eight as you currently have.