Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Yi Zhang
Yi Zhang
3,572 Points
Posted by Yi Zhang
Yi Zhang
3,572 Points

replace method, I don't know where is the error

Can't find the error

index.js 
var utilities = require("./utilities");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

console.log(mergedContent);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
utilities.js 
function merge(content, values) {
  for(var key in values) {
      content.replace("%" + key + "%", values[key]);
  }
  return content;
};


module.exports.merge = merge;

1 Answer

andren
andren
28,558 Points
andren
andren
28,558 Points

The problem is that the replace method does not modify the string it is called on, it return a new string with the content replaced. So you have to assign the result of that operation back to the content variable in order to actually modify it. Like this:

content = content.replace("%" + key + "%", values[key]);

The rest of your code is correct, so you should be able to complete the challenge with just that change.