Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Chanel Weathers
Chanel Weathers
7,003 Points
Posted by Chanel Weathers
Chanel Weathers
7,003 Points

setter method running wrong value?

unsure about what Im doing wrong in this exercise

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

    get major () {
      if ("Junior" || "Senior") {
            return this._major;
        } else {
        return this._major = "none";
        }
    }

    set major(majorpara) {
        this._major = majorpara;
    }
}

var student = new Student(3.9, 60);

1 Answer

Dylan Glover
Dylan Glover
2,537 Points

Hey Chanel,

Pretty sure you just needed to refer to this.level for the "Senior" and "Junior" declarations.

set major(major) {
      if (this.level === "Junior" || this.level === "Senior") {
            this._major = major;
        } else {
            this._major = "None";
        }
    }

    get major() {
        return this._major;
    }

Edit: looks like your get and set were flipped too, this should pass the second part of the challenge Hope this helps,

Dylan

Chanel Weathers
Chanel Weathers
7,003 Points
Chanel Weathers
Chanel Weathers
7,003 Points

Thanks Dylan! that solved the problem.