Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

CSS Sass Basics (retired) Advanced Sass Concepts Interpolating and if/else

setting color to red

I set the colors to the corresponding values but I'm getting a feedback that i should set color to red. don't understand

index.html
<!DOCTYPE html>
<html>
<head>
  <title>Sass Basics - Code Challenge</title>
  <link rel="stylesheet" type="text/css" href="page-style.css">
  <link rel="stylesheet" type="text/css" href="style.css">
</head>
<body>
  <div class="wrap">
    <h1>Hampton's Blog</h1>
    <ul id="menu">
      <li><a href="#">Home</a></li>
      <li><a href="#">About Hampton</a></li>
      <li><a href="#">Hampton's Work</a></li>
    </ul>
    <div class="entry">
      <h1>Delicious Food in SF</h1>
      <div class="content">
        <p>
          You know what my favorite restaurant in San Francisco is? The answer is that there are so many great restaurants that I couldn't choose one. But honorable mentions include Mr. Chow's, Live Sushi and Piccino. 
          <a href="/info.html">Read More</a>
        </p>
      </div>
    </div>
    <div class="entry">
      <h1>Great Music</h1>
        <div class="content">
          <p>
              Here are some of my favorite bands from years past and present: Belle and Sebastian, Pixies, and Daft Punk. Listening to music allows me to focus when I'm programming. 
            <a href="/info.html">Read More</a>
          </p>
        </div>
    </div>
  </div>
</body>
</html>
style.scss
/* Write your SCSS code below. */
@mixin cars($make, $color) {
  .#{$make} {
    border: 1px solid black;
    background-image: url("images/#{$color}.png");

  }
  $time : morning;
  @if $time == morning{
    a{
      color: red;
    }
  }
  @else if $time == afternoon {
     a{
      color: blue;
    }
  }
  @else {
    a{
      color: gray;
    }
  }
}

2 Answers

Hi OLUBUKOLA,

Task 4 of this challenge is meant to be separate from the previous tasks. The if/else directive shouldn't be part of the mixin.

If you take it out and put it below the mixin you should pass.

As a suggestion, you could nest the if/else directive inside a single a rule to avoid the repetition that you have.

$time : morning;

a {
  @if $time == morning{
    color: red;
  }
  @else if $time == afternoon {
    color: blue;
  }
  @else {
    color: gray;
  }
}

That way, if the a selector had to be changed to something else then you only have 1 place to change it instead of 3 places.

Thanks , works now

Thanks , works now