Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Bec Asmar
Bec Asmar
4,403 Points

Stuck with this question

not sure what I'm doing wrong

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }


    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

      get major() {
        return this._major;
      }

      set major(major) {
        if ( this.level == 'Junior' || 'Senior' ) {
          return major;
        } else {
          return 'None';
        }
    }

}

var student = new Student(3.9, 60);

1 Answer

Juan Luna Ramirez
Juan Luna Ramirez
9,038 Points
Juan Luna Ramirez
Juan Luna Ramirez
9,038 Points

Try assigning a value to this._major in your setter function

set major(major) {
  if (this.level === 'Junior' || this.level === 'Senior') {
    // assign the value that was provide if student is junior or senior
    this._major = major
  } else {
    // otherwise ignore the provided value and just assign None
    this._major = 'None'
  }
}