Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Task 1 is no longer passing

i dont know if im missing something in the example.java but it keeps giving me the same error , the only thing i can think of is that when it trows the illegal exception it dosent try again

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
  private String normalizeDiscountCode(String discountCode){
   for(char letter : discountCode.toCharArray()){

   if(!Character.isLetter(letter) || letter != '$'){
     throw new IllegalArgumentException("Invalid Discount Code");

   } 
    }
    discountCode = discountCode.toUpperCase();


     return discountCode;
   }
  }
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);
  String isGood;
   boolean isAcceptable= false;

do{

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      isGood = order.applyDiscountCode("ABC123");
      isAcceptable= true;
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
     isGood =  order.applyDiscountCode("w@w");
     isAcceptable= true;
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
while (!isAcceptable) ;
 return isGood;
  }
}
Brandon Kelly
Brandon Kelly
3,808 Points

Hey Cesar! I struggled with this myself for a bit when I was on this problem. The issue you're running into is that you've used || instead of && in your if statement. When you add the if statement to your code in the second task, the || makes it so the code can never run without throwing the Illegal Argument Exception. It essentially says that if any of the characters aren't letters or if any of the characters aren't $s, throw the exception. A discount code that would fit those parameters is impossible. Simply switch the || to && in the if statement and you'll pass. Happy coding!

1 Answer

It work Thank you. jajaja i never gonna forget this jaja

Brandon Kelly
Brandon Kelly
3,808 Points

Glad you got it. You're very welcome.