Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Task 1 no longer passing

In task 1 of the exercise I made the discount code all upper case by doing:

private String normalizeDiscountCode(String discountCode) { discountCode = discountCode.toUpperCase(); return discountCode; }

Then in part 2 added a for loop to validate that only $ or letters were used, but it keeps saying that "Task 1 no longer passing." Even tried returning "discountCode.toUpperCase();" but to no avail. Completely lost as to why. Any insight would be much appreciated, thanks.

private String normalizeDiscountCode(String discountCode) { discountCode = discountCode.toUpperCase(); for (char letter : discountCode.toCharArray()) { if (letter != '$' || ! Character.isLetter(letter)) { throw new IllegalArgumentException("Invalid discount code"); } } return discountCode; }

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  private String normalizeDiscountCode(String discountCode) {
        discountCode = discountCode.toUpperCase();
    for (char letter : discountCode.toCharArray()) {
      if (letter != '$' || ! Character.isLetter(letter)) {
        throw new IllegalArgumentException("Invalid discount code");
      }
    }
    return discountCode;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return normalizeDiscountCode(discountCode);
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Rares Conea
PLUS
Rares Conea
Courses Plus Student 15,000 Points

Hi,

In normalizeDiscountCode, in your if statement change || with &&

Thank you!