Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript (2015) Constructor Functions and Prototypes Making the UI Work

Nikola Jankovic
Nikola Jankovic
10,793 Points

The console display "this.songs[i].toHTML is not a functio"???

this is my code playlist.js

function Playlist() {
    this.songs= [];
    this.nowPlayingIndex= 0;
}

Playlist.prototype.add = function() {
    this.songs.push(Song);
};

Playlist.prototype.play = function() {
    var currentSong= this.songs[nowPlayingIndex];
    currentSong.play();
};

Playlist.prototype.stop = function(){
    var currentSong= this.songs(nowPlayingIndex);
    currentSong.stop();
};

Playlist.prototype.next = function() {
    this.stop();
    this.nowPlayingIndex++;
    if(this.nowPlayingIndex=== this.songs.length){
        this.nowPlayingIndex= 0;
    }
    this.play();
};

Playlist.prototype.renderInElement = function(list) {
    list.innerHTML= "";
    for(var i= 0; i< this.songs.length; i++){
        list.innerHTML+= this.songs[i].toHTML();
    }
};

, add.js

var playlist= new Playlist();

var hereComesTheSun= new Song('Here Comes The Sun', 'Beatles', '2:54');
var walkingOnSunshine= new Song('Walking On Sunshine', 'Katrina and the Waves', '3:43');

playlist.add(hereComesTheSun);
playlist.add(walkingOnSunshine);

var playlistElement= document.getElementById("playlist");

playlist.renderInElement(playlistElement);

, song.js

function Song(title, artist, duration) {
    this.title= title;
    this.artist= artist;
    this.duration= duration;
    this.isPlaying= false;
}

Song.prototype.play = function() {
    this.isPlaying= true;
};

Song.prototype.stop = function() {
    this.isPlaying= false;
};

Song.prototype.toHTML = function() {
    var htmlString= '<li ';
    if(this.isPlaying){
    htmlString+= 'class="current"';
    }
    htmlString+= '>';
    htmlString+= this.title;
    htmlString+= ' - ';
    htmlString+= '<span calss="duration">'
    htmlString+= this.duration;
    htmlString+= '</span></li>';

    return htmlString;
};

When I run the code it wont show songs and in the console it display error "this.songs[i].toHTML is not a functio". Can someone help????

1 Answer

I quickly looked at your code, I am not 100% sure but I believe you need to call the function without the (), like this:

list.innerHTML+= this.songs[i].toHTML;

Please try this simple change and let us know the result, cheers.

Nikola Jankovic
Nikola Jankovic
10,793 Points

Yes that was the problem, thank's.