Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Omar Lahiani
PLUS
Omar Lahiani
Courses Plus Student 1,123 Points

Throwing exception

Hi !

I'm new to this website so I'mma try my best to explain the problem I'm having , so in this task I'm supposed to only let the user type in a string that contains letters or '$' , so I wrote a for loop at first to go through the string char by char , and If NOT a letter or NOT a '$' symbol encounters , it should throw an exception saying ("invalid discount code") , Else the program should upper case and return the string as in task 1 . Here the error message I keep getting ( Oops! It looks like Task 1 in no longer passing ..) Ps : I tried toCharArray() instead of the for loop , It doesn't work as well :/ , can someone help me figure this out ? I'd appreciate it :)

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);

  }

  private String normalizeDiscountCode(String discountCode){

    for (int i = 0; i < discountCode.length(); i++){
    char c = discountCode.charAt(i);
      if (!Character.isLetter(c) ||c!='$'){
      throw new IllegalArgumentException("Invalid discount code");   
    } 
    }
    this.discountCode = discountCode.toUpperCase();
    return this.discountCode;

 }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Rares Conea
PLUS
Rares Conea
Courses Plus Student 15,000 Points

Hi Omar,

Your code will work if you chage || with your && in your if statement.