Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

CSS Sass Basics (retired) Advanced Sass Concepts Working with Media Queries

Lachlan ∆
Lachlan ∆
8,026 Points

What am I doing wrong on this Sass media query question?

What am I doing wrong? Open a scope on an <ul> with the ID menu. Inside that, open a scope on a <li> element. Using Sass nesting, add a media query so that the <li> elements will have an attribute of text-align: center when the media is screen and the max-width is 500px.

index.html
<!DOCTYPE html>
<html>
<head>
  <title>Sass Basics - Code Challenge</title>
  <link rel="stylesheet" type="text/css" href="page-style.css">
  <link rel="stylesheet" type="text/css" href="style.css">
</head>
<body>
  <div class="wrap">
    <h1>Hampton's Blog</h1>
    <ul id="menu">
      <li><a href="#">Home</a></li>
      <li><a href="#">About Hampton</a></li>
      <li><a href="#">Hampton's Work</a></li>
    </ul>
    <img src="me2.jpeg" alt="">
    <div class="entry">
        <h1>Delicious Food in SF</h1>
        <div class="content">
          <p>
            You know what my favorite restaurant in San Francisco is? The answer is that there are so many great restaurants that I couldn't choose one. But honorable mentions include Mr. Chow's, Live Sushi and Piccino. 
            <a href="/info.html">Read More</a>
          </p>
      </div>
    </div>
    <div class="entry">
      <h1>Great Music</h1>
        <div class="content">
          <p>
              Here are some of my favorite bands from years past and present: Belle and Sebastian, Pixies, and Daft Punk. Listening to music allows me to focus when I'm programming. 
            <a href="/info.html">Read More</a>
          </p>
        </div>
    </div>
  </div>
</body>
</html>
style.scss
/* Write your SCSS code below. */

@media screen and (orientation: landscape) {
  img {
    width: 360px;
  }
}

ul #menu{

    @media screen (max-width: 500px) {
      li {text-align: center;}
    }
}

1 Answer

Liam Maclachlan
Liam Maclachlan
22,805 Points

You have a slight error in you SCSS :)

ul #menu

Should be:

#menu

If you are using an ID selector, they don't need to be pretended with the element as they are the only instance of that ID

It the ID was UL element, it should also be written like this, if you were going to include the UL:

ul#menu

What you have at the moment is looking for a child element with the ID of 'menu' under a UL element; this is what the space will indicate. They should be joining to select the UL with the ID of #menu :)

So, to resolve the problem correctly you have 2 choices (I would go with option 1):

1 - remove the UL before the #menu

2 - remove the space between the ul and the #menu (although this option is not best practice)