JavaScript JavaScript and the DOM Getting a Handle on the DOM Selecting Multiple Elements

Kim Dallas
Kim Dallas
11,461 Points

What did I do wrong?

This should work?

js/app.js
var listItems;
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];
}
let listItems = document.querySelectorAll('#rainbow li');
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
index.html
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

1 Answer

Linas Mackonis
Linas Mackonis
6,423 Points

Hi Kim,

Your code should look like this:

var listItems;
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

listItems = document.querySelectorAll('#rainbow li');

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}

You have declared list items and colors variables twice and you duplicated the for loop.