Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Sebastian Nawrocki
PLUS
Sebastian Nawrocki
Courses Plus Student 2,057 Points

What do I do wrong with this code? Doesn't toCharArray() break discountCode permanently into pieces?

I'm trying to resolve this challenge, part 2 , but I cant do it at all - I keep getting some error. I did use "for (char letter: discountCode.toCharArray())" but does it not break it into array and stays this way? How do we re-assemble this? I am really getting completely lost at this :(.

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;
  private String specialDollarSign = "$$";

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

 private String normalizeDiscountCode (String discountCode) {
     for (char letter : discountCode.toCharArray()) {
       if (!Character.isLetter(letter) || letter != '$') {
         throw new IllegalArgumentException ("Invalid discount code.");
     }
     }
       return discountCode.toUpperCase();
  } 

  public void applyDiscountCode(String discountCode) {
    try {
    this.discountCode = normalizeDiscountCode(discountCode);
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());
  } 
}
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Sebastian Nawrocki
PLUS
Sebastian Nawrocki
Courses Plus Student 2,057 Points

Looks like I just had to swap over || to && in order not to get mistakes.

I re-did exercise and it was stuck on first phase that's why the error occurred. I removed the try,catch also from applyDiscountCode.