Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

HTML

Posted by Aurelian Spodarec
Aurelian Spodarec
7,369 Points

What do you think about this?

Hi,

Another question!

What do you guys think about this ?

http://codepen.io/anon/pen/jEPdPr

Just wondering how does the code looks to you guys and if i could make it better.

I know I'm posting bait of this, but i really need to make the code really good as I'm taking this really seriously .

2 Answers

Jonathan Grieve
MOD
Jonathan Grieve
Treehouse Moderator 91,254 Points
Jonathan Grieve
Jonathan Grieve
Treehouse Moderator 91,254 Points

It looks to me like all that's lacking is a bit of code indentation.

You've certainly commented most of your code which is always good.

I'm not sure it's convention to capitalise the first letter in an ID or Class but it doesn't do any harm I suppose.

Looks good to me otherwise :)

Aurelian Spodarec
Aurelian Spodarec
7,369 Points

oh well, its just a rough work. I want to get like all basics good , even tho this code is a bit messed up in the indentation and capitalisation.

Jonathan Grieve
Jonathan Grieve
Treehouse Moderator 91,254 Points
Jonathan Grieve
Jonathan Grieve
Treehouse Moderator 91,254 Points

To smarten up it's just about spacing rules out, and indenting code, which I'm sure you know. :-)

But we all have our own preferences about how we do that I'm sure. :-)

Aurelian Spodarec
Aurelian Spodarec
7,369 Points

I know , i know , thank you :)

I was just reading an article and it get my writing messy so i call it really rough work just to get an idea : p but now I'm confused of how to get my middle box , in dead middle of the two boxes since i changed values to mine.

Could you see this post if you have time? https://teamtreehouse.com/forum/can-somebody-simplify-this-to-me-please

Ryan Duchene
PLUS
Ryan Duchene
Courses Plus Student 46,022 Points
Ryan Duchene
Ryan Duchene
Courses Plus Student 46,022 Points

It looks good, but there are a couple adjustments I'd make.

The first thing is that it's not responsive; you've set widths and margins in pixels. To make them fluid, you should be using percentages.

Second, a lot of your code can be cleaned up if you use a flexbox layout in place of a float-clearfix layout. This one's a little optional, as flexbox isn't supported before IE10. Once those browsers fall out of favor, though, float-clearfix layouts will completely fade away.

Aurelian Spodarec
Aurelian Spodarec
7,369 Points

Hi,

Im trying to make it like that at the moment since I'm not sure how to make it properly works responsively .

I wanted to make then 1200px and then on tablet view change them and then on mobile view make it 100% width of it and you can scroll.