Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python Dice Roller RPG Roller

what is wrong here ?

import dice

class Hand(list): @property def total(self): return sum(self)

@classmethod
def roll(cls, number_of_dice):
    dicelist = cls()
    for i in range(number):
        dicelist.append(D20())
    return dicelist
dice.py
import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other

class D20(Die):
    def __init__(self, sides=20):
        super().__init__(sides)
hands.py
import dice

class Hand(list):
    @property
    def total(self):
        return sum(self)

    @classmethod
    def roll(cls, number_of_dice):
        dicelist = cls()
        for i in range(number):
            dicelist.append(D20())
        return dicelist    

2 Answers

boi
boi
14,241 Points

I think you solved this challenge so professionally that you made some rookie mistakes.

import dice 👈# Import dice? hmmmmmmmmmmmmm

class Hand(list):
    @property
    def total(self):
        return sum(self)

    @classmethod
    def roll(cls, number_of_dice):
        dicelist = cls()
        for i in range(number): 👈# number? hmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm
            dicelist.append(D20())
        return dicelist 

Thank you !