Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

Posted by Niyamat Almass
Niyamat Almass
8,176 Points

what wrong with my code ?

i do exactly the same code in the video but what wrong in my code

app.js 
var $select = $("<select></select>");
$("#menu").append($select);


$("#menu a").each(function() {
var $acnchor = (this);
  var $option = ("<option></option>");
  $option.val($acnchor.attr("href"));
  $option.text($acnchor.Text());
  $select.append($option);


});

1 Answer

Salman Akram
Salman Akram
Courses Plus Student 40,065 Points

Hi Niyamat,

After reviewing your codes compared to Instructor's example. I still find some minor mistakes, see below:

var $acnchor = (this);

Note: $ is missing

var $option = ("<option></option>");

Note: $ is missing

 $option.text($acnchor.Text());

Note: wrong capital letter "Text" ?

var $acnchor = (this);
  var $option = ("<option></option>");
  $option.val($acnchor.attr("href"));
  $option.text($acnchor.Text());

Note: acnchor ?

See full details again at 7:53

Hope that helps :)

-Salman

Niyamat Almass
Niyamat Almass
8,176 Points

thank you so much.but in the video when a drop down menu is selected.the page what is displayed is check in drop down menu.but that didn't happen me!!

app.js 
var $select = $("<select></select>");
$("#menu").append($select);


$("#menu a").each(function() {
var $anchor = $(this);
  var $option = $("<option></option>");
  $option.val($anchor.attr("href"));
  $option.text($anchor.text());
  $select.append($option);


});
Salman Akram
Salman Akram
Courses Plus Student 40,065 Points

Have you put app.js file inside javascript folder? Did you add two scripts from index.html on the bottom?

    <script src="http://code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
    <script src="js/app.js" type="text/javascript" charset="utf-8"></script>

Check your HTML files to make sure all the scripts, selected class properly and also href links.

Niyamat Almass
Niyamat Almass
8,176 Points

my html code and jquery code is

index.html 
<!DOCTYPE html>
<html>
<head>
<link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
</head>
<body>
    <div id="menu">
        <ul>
            <li class="selected"><a href="index.html">Home</a></li>
            <li><a href="about.html">About</a></li>
            <li><a href="contact.html">Contact</a></li>
            <li><a href="support.html">Support</a></li>
            <li><a href="faqs.html">FAQs</a></li>
            <li><a href="events.html">Events</a></li>
        </ul>
    </div>
    <h1>Home</h1>
    <p>This is the home page.</p>
    <script src="http://code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
    <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>
app.js 
var $select = $("<select></select>");
$("#menu").append($select);


$("#menu a").each(function() {
var $anchor = $(this);
  var $option = $("<option></option>");
  $option.val($anchor.attr("href"));
  $option.text($anchor.text());
  $select.append($option);


});