Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Furkan Demirtürk
Furkan Demirtürk
7,940 Points
Posted by Furkan Demirtürk
Furkan Demirtürk
7,940 Points

Whats wrong there?

Whats wrong there?

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
  set major (major){

  if( this.level == "Senior "||"Junior"){
      this._major = major; 
  }else if ( this.level == "Sophomore "||"Freshman") {
     this._major = "None";
  }
  }
}

var student = new Student(3.9, 60);

2 Answers

Aakash Srivastav
seal-mask
.a{fill-rule:evenodd;}techdegree
Aakash Srivastav
Full Stack JavaScript Techdegree Student 11,638 Points
Aakash Srivastav
.a{fill-rule:evenodd;}techdegree
Aakash Srivastav
Full Stack JavaScript Techdegree Student 11,638 Points

Hey Furkan Demirtürk , you have done good job. Just a little issue.

  1. You have not set the getter for your setter. There is always a getter for your setter that return the value of setter
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

  set major(major){
  if( this.level == "Senior" ||  "Junior"){
      this._major = major; 
  }else if ( this.level == "Sophomore " ||  "Freshman") {
     this._major = "None";
  }
  }

  get major(){                        // This is the getter that return the value of setter
    return this._major;
  }
}

var student = new Student(3.9, 60);
Furkan Demirtürk
Furkan Demirtürk
7,940 Points
Furkan Demirtürk
Furkan Demirtürk
7,940 Points

Thank u so much but I still take the same warning. "Bummer: Your setter method is returning the wrong value for the major property" Can be there another mistake except that you found?

Aakash Srivastav
seal-mask
.a{fill-rule:evenodd;}techdegree
Aakash Srivastav
Full Stack JavaScript Techdegree Student 11,638 Points
Aakash Srivastav
.a{fill-rule:evenodd;}techdegree
Aakash Srivastav
Full Stack JavaScript Techdegree Student 11,638 Points

Can you tell me Furkan Demirtürk , what you are trying to achieve as per instruction?
There is some problem with my account and I am unable to open that particular challenge