What's wrong with my code?

Question

It says that I'm not returning the right index value but as far as I can see I I've set up the loop correctly.

todo_list.rb

class TodoList
  attr_reader :name, :todo_items

  def initialize(name)
    @name = name
    @todo_items = []
  end

  def add_item(name)
    todo_items.push(TodoItem.new(name))
  end


    def find_index(name)
    index = 0
    found = false
    todo_items.each do |todo_item|
      if todo_item.name == name
        found = true
      end
      index += 1
      break if found
    end
    if found
      return index
    else
      return false
    end
end

end

Answer 1 · 2016-01-21T21:08:06Z

January 21, 2016 9:08pm

Hi Patrick,

The problem is that you increment the index variable before you break from the loop. The index you return is then going to be one higher than what it was when the match is found.

You could put a break statement inside the if block. That way you break immediately out of the loop and index has the correct value. If the name didn't match then you increment the index and loop again.

The other issue is that you're returning false if it wasn't found but the instructions say to return nil.

I would just leave off the else part at the end and it will automatically return nil if it reaches that far.

Welcome to the Treehouse Community

Looking to learn something new?

Patrick Mockridge

Patrick Mockridge

What's wrong with my code?

1 Answer

Jason Anello

Jason Anello