Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

PHP Build a Basic PHP Website (2018) Enhancing a Form Escaping Output

Posted by Kohane Kagami
Kohane Kagami
12,390 Points

What's wrong with this code?

Here is the quiz. "The PHP file below includes another PHP file that retrieves information from an external source for a directory listing. The page is supposed to display two input fields and a textarea, but it contains some malicious code. Modify the PHP code below to escape the output and display the correct HTML elements on the screen."

And I got this error. "! I still see some malicious code in there. You want to escape the name variable before displaying it to the screen." "PHP Notice: Undefined index: name in views_listing_edit.php on line 13 PHP Notice: Undefined index: link in views_listing_edit.php on line 21 PHP Notice: Undefined index: description in views_listing_edit.php on line 29"

and here is the code.

views_listing_edit.php 
<?php require_once("controllers_listing.php"); ?><html>
<body>

    <h1>Edit Listing</h1>

    <form method="post">
        <table>
            <tr>
                <th>
                    <label for="name">Name</label>
                </th>
                <td>
                    <input id="name" name="name" value="<?php if(isset($listing_name)){echo htmlspecialchars($_POST["name"]); }?>">
                </td>
            </tr>
            <tr>
                <th>
                    <label for="Link">Link</label>
                </th>
                <td>
                    <input id="link" name="link" value="<?php if(isset ($listing_link)){echo htmlspecialchars($_POST["link"]);} ?>">
                </td>
            </tr>
            <tr>
                <th>
                    <label for="Description">Description</label>
                </th>
                <td>
                    <textarea id="description" name="description"><?php if(isset($listing_description)){echo htmlspecialchars($_POST["description"]); }?></textarea>
                </td>
            </tr>    
        </table>
        <input type="submit" value="Save">
    </form>

</body>
</html>

2 Answers

Henrik Hansen
Henrik Hansen
23,176 Points
Henrik Hansen
Henrik Hansen
23,176 Points

All you have to do is wrap the variables in the htmlspecialchars function.

Kohane Kagami
Kohane Kagami
12,390 Points
Kohane Kagami
Kohane Kagami
12,390 Points

Thank you very much. :)