Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android Implementing Designs for Android Using Custom Styles and Themes Styling EditTexts and Buttons

Posted by MUZ140820 Immaculate Ncube
MUZ140820 Immaculate Ncube
4,611 Points

where am i getting it wrong?its giving me a bummer

please help

styles.xml 
<resources xmlns:android="http://schemas.android.com/apk/res/android">

  <style name="CustomEditText"/> // <<-- is the error there?
   <item name="android:textSize">20sp<item/>
    <item name="android:textColor">@Color/dark_green<item/>
    <item name="android:layout_width">match_parent<item/>
    <item name="android:layout_height">wrap_content<item/>
    <item name="android:layout_alignParentLeft">true<item/> 

      </style>

</resources>
activity_main.xml 
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent" >

    <EditText
        android:id="@+id/nameField"
        android:layout_alignParentTop="true"
        android:hint="@string/hint_name"
         style="@style/CustomEditText"/>

    <EditText
        android:id="@+id/cityField"
        android:layout_below="@id/nameField"
        android:hint="@string/hint_city"
        style="@style/CustomEditText"/>

</RelativeLayout>

2 Answers

Steve Hunter
Steve Hunter
57,712 Points

I think you've closed the style tag prematurely. You've added a "/" at the end of the line - try removing that.

My code looks the same, but I'll paste it below for you to check!

styles.xml 
<resources xmlns:android="http://schemas.android.com/apk/res/android">
  <style name="CustomEditText">  /* <-- you have an extra slash at the end of this line */
    <item name="android:layout_width">match_parent</item>
    <item name="android:layout_height">wrap_content</item>
    <item name="android:textSize">20sp</item>
    <item name="android:textColor">@color/dark_green</item>
    <item name="android:layout_alignParentLeft">true</item>
  </style>
</resources>
activity_main.xml 
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent" >

    <EditText
        android:id="@+id/nameField"
        android:layout_alignParentTop="true"
        android:hint="@string/hint_name"
        style="@style/CustomEditText" />

    <EditText
        android:id="@+id/cityField"
        android:layout_below="@id/nameField"
        android:hint="@string/hint_city"
        style="@style/CustomEditText" />

</RelativeLayout>
yazan khateeb
PLUS
yazan khateeb
Courses Plus Student 2,575 Points
yazan khateeb
yazan khateeb
Courses Plus Student 2,575 Points

just remove slash from tag style because it has property , like this :-

<resources xmlns:android="http://schemas.android.com/apk/res/android">

  <style name="CustomEditText"> 
   <item name="android:textSize">20sp<item/>
    <item name="android:textColor">@Color/dark_green<item/>
    <item name="android:layout_width">match_parent<item/>
    <item name="android:layout_height">wrap_content<item/>
    <item name="android:layout_alignParentLeft">true<item/> 

      </style>

</resources>