Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Getter Methods

Posted by Frans Joakim Titulaer
Frans Joakim Titulaer
5,001 Points

Why is it returning the wrong student level?

Almost positive this is right. Why does it return the wrong studen level!?

get level() { if(this.credits > 90) { return 'Sernior' } else if (this.credits >= 61) { return 'Junior' } else if (this.credits >= 31) { return 'Sophmore' } else { return 'Freshman' } }

creating_getters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    get level() {
      if(this.credits > 90) {
        return 'Sernior'
      } else if (this.credits >= 61) {
        return 'Junior'
      } else if (this.credits >= 31) {
        return 'Sophmore'
      } else {
        return 'Freshman'
      }
    }

    stringGPA() {
        return this.gpa.toString();
    }
}

const student = new Student(3.9);

2 Answers

Frans Joakim Titulaer
Frans Joakim Titulaer
5,001 Points

Sorry, I made some spelling mistakes

Mil Kapil
Mil Kapil
15,484 Points
Mil Kapil
Mil Kapil
15,484 Points

The question is tricky because it gives an incorrect hint -> Needs to be greater than 60 to be Junior and greater than 30 to be a sophomore.

So if somebody has 60.5 Credits, are they a junior? The current code says sophomore, which is incorrect.