Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript JavaScript Basics (Retired) Working With Numbers The Random Challenge Solution

Why is this not working?

var topNumber = prompt('Enter the biggest number'); parseInt(topNumber); var bottomNumber = prompt('Enter the lowest number'); parseInt(bottomNumber); var randomNumber = Math.floor(Math.random() * (topNumber - bottomNumber + 1)) + bottomNumber; var message = "You are random number is "+ randomNumber; document.write(message);

1 Answer

You need to assign the result of parseInt() to something i.e. topNumber = parseInt(topNumber), bottomNumber = parseInt(bottomNumber) to convert to an integer. As is what your code does is in the comments:

var topNumber = prompt('Enter the biggest number');
parseInt(topNumber); //this does nothing
var bottomNumber = prompt('Enter the lowest number');
parseInt(bottomNumber);  //this does nothing

var randomNumber = Math.floor(Math.random() * (topNumber - bottomNumber + 1)) + bottomNumber;  //this concatenates bottomNumber

var message = "You are random number is "+ randomNumber; 

document.write(message);

The following code works as expected:

var topNumber = prompt('Enter the biggest number');
topNumber = parseInt(topNumber);
var bottomNumber = prompt('Enter the lowest number');
bottomNumber = parseInt(bottomNumber);

var randomNumber = Math.floor(Math.random() * (topNumber - bottomNumber + 1)) + bottomNumber; 

var message = "You are random number is "+ randomNumber; 

document.write(message);